lhotari commented on code in PR #24596:
URL: https://github.com/apache/pulsar/pull/24596#discussion_r2250774574
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1404,13 +1404,13 @@ protected void handleSubscribe(final CommandSubscribe
subscribe) {
if (consumerFuture.complete(consumer)) {
log.info("[{}] Created subscription on topic
{} / {}",
- remoteAddress, topicName,
subscriptionName);
+ remoteAddress, topicName,
subscriptionName); // TODO consumer id.
Review Comment:
Please omit adding TODOs in this PR. You can keep the TODOs to yourself and
handle these in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
