3pacccccc commented on code in PR #24607:
URL: https://github.com/apache/pulsar/pull/24607#discussion_r2255676143
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -201,6 +202,7 @@ public void markDeleteComplete(Object ctx) {
@Override
public void markDeleteFailed(ManagedLedgerException exception, Object
ctx) {
log.warn("[{}][{}] Message expiry failed - mark delete failed",
topicName, subName, exception);
+ expirationCheckInProgress = FALSE;
Review Comment:
is it better to set ```expirationCheckInProgress = FALSE;``` after
```updateRates();```? otherwise there might still be a chance of this issue
occurring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
