3pacccccc commented on code in PR #24609: URL: https://github.com/apache/pulsar/pull/24609#discussion_r2257665825
########## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/EntryCacheManagerTest.java: ########## Review Comment: thank you for your suggestions @lhotari But I think The root cause of this test flakiness stems from incorrect assumptions about eviction timing. Currently, eviction occurs immediately after inserting ```EntryImpl.create(2, 2, new byte[1])```, but the test incorrectly assumes eviction happens during the next insertion. The test's original intention appears to be verifying when eviction gets triggered, but it mispredicts the exact trigger point. I think we don't need to manually blocking evictions. Or Maybe I don't get your point, Would you like to show me how to properly deal with it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
