JamesMurkin opened a new pull request, #1419:
URL: https://github.com/apache/pulsar-client-go/pull/1419

   
   ### Motivation
   
   The properties on messages returned by PeekMessages is not returned 
consistently as described in #1418 
   
   This change makes sure we set all properties from headers before continuing 
on, so the returned message should consistently contain all properties.
   
   Currently the properties returned is inconsistent on repeated calls, even if 
the message returned is the same each time.
   
   ### Modifications
   
   I've made it so all headers are processed / al properties are set on every 
message, rather than exiting the loop early which can cause inconsistent 
results.
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to