lhotari opened a new pull request, #24699: URL: https://github.com/apache/pulsar/pull/24699
### Motivation While profiling Pulsar with PulsarProfilingTest, I noticed that a significant part of CPU of an insert to the cache is spent in the existence check. The case where the entry might already be in the cache is already covered by putIfAbsent and it is very rare after the PendingReadsManager solution was introduced to de-duplicate reads. ### Modifications - remove the exists check before inserting to cache ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
