shibd commented on code in PR #24730:
URL: https://github.com/apache/pulsar/pull/24730#discussion_r2343529553
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/HashRangeExclusiveStickyKeyConsumerSelectorTest.java:
##########
@@ -189,6 +221,32 @@ public void
testGetConsumerKeyHashRangesWithSameConsumerName() throws Exception
}
}
+ @Test
+ public void testOneConsumerRangeConflict() throws ExecutionException,
InterruptedException {
Review Comment:
I changed name to `testShouldConflictConsumerWithSelfOverlappingRanges`
This test is to ensure that a single consumer is not allowed if its own hash
ranges conflict with each other. the client-side already prevents this case,
but on the broker-side, having an additional layer of validation makes it safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
