GitHub user LucasEby created a discussion: Single Pull Request or Multiple Pull Requests for Similar Fixes
I apologize if this question has been asked already, I wasn't able to find an answer with the searching I did. I found a similar issue in the 7 different test methods below. I have fixed the problems in my fork already. Since each of these tests are inside completely different areas of the code base, would you prefer for me to submit a single PR with all of the tests fixed inside of it (Option A) or separate PR's for each fix (Option B)? Files modified (along with some pom.xmls): - org.apache.pulsar.common.policies.data.NamespaceOwnershipStatusTest#testSerialization - org.apache.pulsar.common.policies.impl.NamespaceIsolationPoliciesTest#testJsonSerialization - org.apache.pulsar.functions.utils.FunctionConfigUtilsTest#testConvertBackFidelity - org.apache.pulsar.functions.utils.SinkConfigUtilsTest#testConvertBackFidelity - org.apache.pulsar.functions.utils.SourceConfigUtilsTest#testBatchConfigMergeEqual - org.apache.pulsar.io.elasticsearch.ElasticSearchExtractTest#testGenericRecord - org.apache.pulsar.io.kinesis.UtilsTest#testKeyValueSerializeNoValue. GitHub link: https://github.com/apache/pulsar/discussions/24808 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
