lhotari opened a new pull request, #24811:
URL: https://github.com/apache/pulsar/pull/24811

   ### Motivation
   
   Apache Parent POM was updated from version 29 to 35 in PR #24742. That broke 
`mvn deploy` with this type of error message:
   
   ```
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-source-plugin:3.3.1:jar-no-fork (attach-sources) 
on project pulsar-client-all: Presumably you have configured 
maven-source-plugin to execute twice in your build. You have to configure a 
classifier for at least one of them. -> [Help 1]
   ```
   
   ### Modifications
   
   Set `attach-sources` phase to `none` for `maven-source-plugin` when 
`maven-shade-plugin` has been configured with 
`<createSourcesJar>true</createSourcesJar>`. This currently applies to 
`pulsar-client-all` module.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to