lhotari commented on code in PR #24423: URL: https://github.com/apache/pulsar/pull/24423#discussion_r2370241359
########## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ########## Review Comment: I just hope that this doesn't result in cherry-picking parts separately since that would break functionality in at least branch-3.3, branch-4.0 and branch-4.1 if all parts of the implementation aren't completed and cherry-picked together once they are completed and properly addressing for example the autoread detail that I have so many times reminded about and which you are aware of. Since releases 4.1.1, 4.0.7 and 3.3.9 are about to start, please don't cherry-pick partial implementations to those branches along the way. In branch-3.0 the rate limiting is broken in any case since there's no coordination across autoread toggling so it doesn't really matter for branch-3.0. As long as the feature is disabled by default and a no-op, it's fine for branch-3.0 even if there wouldn't be all parts of the implementation when it lands there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
