lhotari commented on code in PR #24833:
URL: https://github.com/apache/pulsar/pull/24833#discussion_r2429738228
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java:
##########
@@ -288,8 +294,13 @@ public void deleteTopicListWatcher(Long watcherId) {
*/
public void sendTopicListUpdate(long watcherId, String topicsHash,
List<String> deletedTopics,
List<String> newTopics) {
- connection.getCommandSender().sendWatchTopicListUpdate(watcherId,
newTopics, deletedTopics, topicsHash);
+ connection.getCommandSender().sendWatchTopicListUpdate(watcherId,
newTopics, deletedTopics, topicsHash,
+ t -> {
+ // TODO add retry with backoff
+ log.warn(
+ "[{}] Cannot acquire direct memory tokens for
sending topic list update. State will be "
+ + "inconsistent on the client. {}",
+ connection.toString(), t.getMessage());
+ });
Review Comment:
I'm handling this with changes to address the retry with backoff which is
currently a TODO. I'll push the changes very soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
