Dream95 commented on code in PR #24826:
URL: https://github.com/apache/pulsar/pull/24826#discussion_r2439007599


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -232,6 +232,11 @@ public CompletableFuture<TransactionMeta> 
getTransactionMeta(TxnID txnID) {
         return CompletableFuture.completedFuture(null);
     }
 
+    @VisibleForTesting
+    public void setPublishFuture(CompletableFuture<Position> publishFuture) {
+        this.publishFuture = publishFuture;
+    }

Review Comment:
   I have already removed the `publishFuture` and  `transactionBufferFuture` 
field, do I also need to remove the `state` field. @lhotari 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to