lhotari commented on code in PR #23989:
URL: https://github.com/apache/pulsar/pull/23989#discussion_r2417368797
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java:
##########
@@ -718,6 +718,13 @@ ClientBuilder authentication(String authPluginClassName,
Map<String, String> aut
*/
ClientBuilder lookupProperties(Map<String, String> properties);
+ /**
+ * Set the max retry times for a request.
+ *
+ * @param maxRetryTimes
+ * @return the client builder instance
+ */
+ ClientBuilder maxRetryTimes(int maxRetryTimes);
Review Comment:
`maxRetryTimes` is not very descriptive. Since this is about http client
retries, it should be also explained in the javadoc and the method name and
parameter name should also make that obvious.
`maxHttpRequestRetries` would be one choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
