3pacccccc opened a new pull request, #24848: URL: https://github.com/apache/pulsar/pull/24848
### Motivation Currently, when setting a clock for the Pulsar client, there is no null check for the clock parameter. This can cause a NullPointerException when sending messages if a null clock is passed.[1] [1]: https://github.com/apache/pulsar/blob/45d71f8fcdd58d8715ada7e418f3acd8b43c141a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L710 ### Modifications This PR adds a null check for the clock parameter to provide a clear error message and prevent NPEs. <!-- Describe the modifications you've done. --> ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/3pacccccc/pulsar/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
