LucasEby commented on code in PR #24877:
URL: https://github.com/apache/pulsar/pull/24877#discussion_r2442740345


##########
pulsar-io/kafka/src/test/java/org/apache/pulsar/io/kafka/sink/KafkaAbstractSinkTest.java:
##########
@@ -65,7 +68,7 @@ private static <T extends Exception> void 
expectThrows(Class<T> expectedType, St
         } catch (Throwable e) {
             if (expectedType.isInstance(e)) {
                 T ex = expectedType.cast(e);
-                assertEquals(expectedMessage, ex.getMessage());
+                assertEquals(ex.getMessage(), expectedMessage);

Review Comment:
   This line was a separate small bug. Actual comes before expected in Testng 
assertEquals method: 
https://www.javadoc.io/doc/org.testng/testng/6.8.17/org/testng/Assert.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to