Copilot commented on code in PR #1434:
URL: https://github.com/apache/pulsar-client-go/pull/1434#discussion_r2476236499
##########
pulsar/consumer_zero_queue_test.go:
##########
@@ -240,6 +243,92 @@ func TestReconnectConsumer(t *testing.T) {
defer c.Terminate(ctx)
}
+func TestUnloadTopicBeforeConsume(t *testing.T) {
+
+ sLogger := slog.New(slog.NewTextHandler(os.Stdout,
&slog.HandlerOptions{Level: slog.LevelDebug}))
+ client, err := NewClient(ClientOptions{
+ URL: lookupURL,
+ Logger: plog.NewLoggerWithSlog(sLogger),
+ })
+ assert.Nil(t, err)
+ admin, err := pulsaradmin.NewClient(&config.Config{})
+ assert.Nil(t, err)
+
+ assert.Nil(t, err)
Review Comment:
Duplicate error check at line 257. The error was already checked at line
255, making this assertion redundant.
```suggestion
```
##########
pulsar/consumer_zero_queue_test.go:
##########
@@ -240,6 +243,92 @@ func TestReconnectConsumer(t *testing.T) {
defer c.Terminate(ctx)
}
+func TestUnloadTopicBeforeConsume(t *testing.T) {
+
+ sLogger := slog.New(slog.NewTextHandler(os.Stdout,
&slog.HandlerOptions{Level: slog.LevelDebug}))
+ client, err := NewClient(ClientOptions{
+ URL: lookupURL,
+ Logger: plog.NewLoggerWithSlog(sLogger),
+ })
+ assert.Nil(t, err)
+ admin, err := pulsaradmin.NewClient(&config.Config{})
+ assert.Nil(t, err)
+
+ assert.Nil(t, err)
+ defer client.Close()
+
+ topic := newTopicName()
+ ctx := context.Background()
+ consumer, err := client.Subscribe(ConsumerOptions{
+ Topic: topic,
+ SubscriptionName: "my-sub",
+ EnableZeroQueueConsumer: true,
+ })
+
+ assert.Nil(t, err)
+ _, ok := consumer.(*zeroQueueConsumer)
+ assert.True(t, ok)
+ defer consumer.Close()
+
+ // create producer
+ producer, err := client.CreateProducer(ProducerOptions{
+ Topic: topic,
+ DisableBatching: false,
+ })
+ assert.Nil(t, err)
+
+ // send 10 messages
+ for i := 0; i < 10; i++ {
+ msg, err := producer.Send(ctx, &ProducerMessage{
+ Payload: []byte(fmt.Sprintf("hello-%d", i)),
+ Key: "pulsar",
+ Properties: map[string]string{
+ "key-1": "pulsar-1",
+ },
+ })
+ assert.Nil(t, err)
+ log.Printf("send message: %s", msg.String())
+ }
+
+ log.Println("unloading topic")
+ topicName, err := utils.GetTopicName(topic)
+ assert.Nil(t, err)
+ // unload topic to trigger consumer reconnect and send a permits
Review Comment:
Grammar issue: 'send a permits' should be 'send permits' (remove 'a').
```suggestion
// unload topic to trigger consumer reconnect and send permits
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
