lhotari commented on issue #24924: URL: https://github.com/apache/pulsar/issues/24924#issuecomment-3471579480
Sounds good. > For the new tests, I am thinking something like this: > > 1. A new `ScyllaDBContainer` class in tests/integration/containers > 2. A new ScyllaDBSinkTester in integration/io/sinks (using the same Sink class as Cassandra) > 3. New methods in `PulsarSinksTest` - `testScyllaDBSink` and `testScyllaDBArchiveSink` As a pre-requisite for running the tests, Pulsar's test docker images would have to be built locally. You can handle that with the instructions in https://github.com/apache/pulsar/blob/master/tests/README.md (might not be accurate). This should be the fastest way to prepare and run the tests: ``` # build integration tests with dependencies mvn -am -pl tests/integration -Dcheckstyle.skip=true -Dlicense.skip=true -Dspotbugs.skip=true -DskipTests install # build apachepulsar/java-test-image:latest (tests/docker-images/java-test-image/Dockerfile) which is faster to build than the complete test image apachepulsar/pulsar-test-latest-version:latest (tests/docker-images/latest-version-image/Dockerfile) ./build/build_java_test_image.sh # test image name is set at tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/PulsarContainer.java#L61-L62 # https://github.com/apache/pulsar/blob/15daf18a877cddc3786dc0661fde0e049bac916a/tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/PulsarContainer.java#L61-L62 # you can modify that line to point to apachepulsar/java-test-image:latest or set the env variable export PULSAR_TEST_IMAGE_NAME=apachepulsar/java-test-image:latest # run the tests mvn -DintegrationTests -pl tests/integration -Dtest=PulsarSinksTest#testScyllaDBSink,PulsarSinksTest#testScyllaDBArchiveSink -DtestRetryCount=0 \ -DredirectTestOutputToFile=false test ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
