lhotari commented on code in PR #24833:
URL: https://github.com/apache/pulsar/pull/24833#discussion_r2494351811
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java:
##########
@@ -101,6 +112,7 @@ public void accept(String topicName, NotificationType
notificationType) {
private final boolean enableSubscriptionPatternEvaluation;
private final int maxSubscriptionPatternLength;
private final ConcurrentLongHashMap<CompletableFuture<TopicListWatcher>>
watchers;
+ private final Backoff retryBackoff;
public TopicListService(PulsarService pulsar, ServerCnx connection,
Review Comment:
> That situation is what I want to say. It will cause consumers to be unable
to receive messages that were sent to the new partitions until the client
application restarts.
That doesn't hold since the solution will retry with back off in case of
errors.
There's some additional changes that I'll need to make.
* There is a need to stop retries
* if the watcher is closed
* the connection is closed
* operations should be handled in order
* retrying could break the ordering currently
I'll follow up with changes to address the above issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
