lhotari commented on code in PR #1052:
URL: https://github.com/apache/pulsar-site/pull/1052#discussion_r2509758571


##########
docs/security-oauth2.md:
##########
@@ -236,6 +236,9 @@ The following table outlines the parameters of the 
`client_credentials` authenti
 | `privateKey` | The URL to the JSON credentials file.  | Support the 
following pattern formats: <br /> <li> `file:///path/to/file` 
</li><li>`file:/path/to/file` </li><li> 
`data:application/json;base64,<base64-encoded value>` </li>| Required |
 | `audience`  | The OAuth 2.0 "resource server" identifier for a Pulsar 
cluster. | `https://broker.example.com` | Optional |
 | `scope` |  The scope of an access request. <br />For more information, see 
[access token 
scope](https://datatracker.ietf.org/doc/html/rfc6749#section-3.3). | 
api://pulsar-cluster-1/.default | Optional |
+| `connectTimeout` | The connection timeout in milliseconds. Default value: 
10s. Only implemented in java client. | 10000 | Optional |
+| `readTimeout` | The read timeout in milliseconds. Only implemented in java 
client. Default value: 30s. | 30000 | Optional |

Review Comment:
   The unit "milliseconds" doesn't match the current implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to