lhotari commented on PR #24965: URL: https://github.com/apache/pulsar/pull/24965#issuecomment-3515217524
> > > Why could take the method params into account ? There will be more request to the broker, but the result is the same. > > > > > > @Technoboy- I think that this is more about correctness than the possibility that the broker response might be the same in most cases. It's strictly not the same in all cases. Therefore I think that such bugs should be fixed. > > This is not a bug I think that depends on how you define a bug. The impact of the issue is that `boolean metadataAutoCreationEnabled, boolean useFallbackForNonPIP344Brokers` parameters for the `getPartitionedTopicMetadata` method are ignored for any other requests which are made while there's a request in progress. Let's say that the first request is made with `metadataAutoCreationEnabled=false` and while it's in progress a request with `metadataAutoCreationEnabled=true` is made. This will definitely result in an inconsistent situation. However, I agree that the likelihood that this would happen is low. Regardless of that, such issues should be fixed and I would consider them bugs. Your definition of a bug could vary and I think it's fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
