lhotari commented on code in PR #24994:
URL: https://github.com/apache/pulsar/pull/24994#discussion_r2534483932
##########
pulsar-opentelemetry/src/test/java/org/apache/pulsar/opentelemetry/OpenTelemetryServiceTest.java:
##########
@@ -116,9 +114,8 @@ public void testResourceAttributesAreSet() throws Exception
{
.allSatisfy(metric -> assertThat(metric)
.hasResourceSatisfying(resource -> resource
.hasAttribute(OpenTelemetryAttributes.PULSAR_CLUSTER,
"testServiceNameAndVersion")
- .hasAttribute(ResourceAttributes.SERVICE_NAME,
"openTelemetryServiceTestService")
- .hasAttribute(ResourceAttributes.SERVICE_VERSION, "1.0.0")
- .hasAttribute(satisfies(ResourceAttributes.HOST_NAME,
AbstractCharSequenceAssert::isNotBlank))));
Review Comment:
It has been moved to
https://github.com/open-telemetry/semantic-conventions-java/blob/83685172f51260299e59f6eada180060f44d9970/semconv-incubating/src/main/java/io/opentelemetry/semconv/incubating/HostIncubatingAttributes.java#L92-L96
which is part of opentelemetry-semconv-incubating dependency. It seems that
testing for the host name attribute isn't relevant in this test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
