oneby-wang commented on PR #24912: URL: https://github.com/apache/pulsar/pull/24912#issuecomment-3606030181
Hi, @Technoboy-, thanks for reminding me. This PR is covered by existing test, see `InactiveTopicDeleteTest#testWhenSubPartitionNotDelete()` test method. But I configured the admin `connectionsPerBroker` param of `PulsarService` incorrectly before, now it is correct, see commit: https://github.com/apache/pulsar/pull/24912/commits/edaff51ceba81462b5f95b5e593e94ccfc57b96c. Without this PR's fix, `InactiveTopicDeleteTest#testWhenSubPartitionNotDelete()` test method will fail due to assert timeout, because admin client connection(just one, which is the default value in real pulsar broker) is exhausted due to connection pool deadlock, and test failure messages like this: ``` org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.apache.pulsar.broker.service.InactiveTopicDeleteTest expected [false] but found [true] within 10 seconds. at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985) at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:769) ``` This PR fixes the issue, so it can pass now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
