dannf opened a new pull request, #527:
URL: https://github.com/apache/pulsar-client-cpp/pull/527

   Fixes #478 
   
   ### Motivation
   
   Our `libpulsar` builds started failing with latest upstream dependencies 
(abseil-cpp/protobuf). After creating this patch, I noticed @cho-m had already 
reported an issue and suggested a couple fixes, which are likely better than 
this. But that was months ago, so I figured I'd open a PR to push the 
conversation forward.
   
   ### Modifications
   
   Explicitly convert absl string_view to std::string for use in the schemaJson.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Documentation
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   No user-visible changes.
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to