oneby-wang commented on code in PR #25050:
URL: https://github.com/apache/pulsar/pull/25050#discussion_r2601835790
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -1245,45 +1245,68 @@ public void setPersistence(@Suspended final
AsyncResponse asyncResponse, @PathPa
}
@POST
- @Path("/{property}/{cluster}/{namespace}/persistence/bookieAffinity")
+ @Path("/{tenant}/{cluster}/{namespace}/persistence/bookieAffinity")
Review Comment:
Question: in v1 `Namespaces`, many path variables are named as property, not
tenant, should I change the variable name here?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -1013,7 +1013,7 @@ protected CompletableFuture<Void>
internalUnloadNamespaceAsync() {
});
}
-
+ @Deprecated
protected void internalSetBookieAffinityGroup(BookieAffinityGroupData
bookieAffinityGroup) {
Review Comment:
Question: this method is no longer used after this PR's refactor, should I
remove it or just keep it as deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
