TakaHiR07 commented on code in PR #25076:
URL: https://github.com/apache/pulsar/pull/25076#discussion_r2625484798
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/delayed/InMemoryDeliveryTrackerTest.java:
##########
@@ -274,4 +274,69 @@ public void
testDelaySequence(InMemoryDelayedDeliveryTracker tracker) throws Exc
tracker.close();
}
+ @Test(dataProvider = "delayedTracker")
+ public void
testDelayedMessagesCountWithDuplicateEntryId(InMemoryDelayedDeliveryTracker
tracker) throws Exception {
+ assertFalse(tracker.hasMessageAvailable());
+
+ // case1: addMessage() with duplicate entryId,
+ // getScheduledMessages() enter "cardinality <= n" and make tracker
empty
+ assertTrue(tracker.addMessage(1, 1, 10));
+ assertTrue(tracker.addMessage(1, 2, 20));
+ assertTrue(tracker.addMessage(1, 2, 20));
+ assertTrue(tracker.addMessage(1, 3, 40));
+ assertTrue(tracker.addMessage(1, 4, 50));
+
+ clockTime.set(50);
+ assertTrue(tracker.hasMessageAvailable());
+ assertEquals(tracker.getNumberOfDelayedMessages(), 4L);
+ assertEquals(tracker.delayedMessageMap.size(), 4L);
+
+ Set<Position> scheduled = tracker.getScheduledMessages(10);
+ assertEquals(scheduled.size(), 4);
+ assertEquals(tracker.getNumberOfDelayedMessages(), 0L);
+
+
+
+ // case2: addMessage() with duplicate entryId,
Review Comment:
Yes. have changed the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
