BewareMyPower commented on code in PR #445:
URL:
https://github.com/apache/pulsar-client-node/pull/445#discussion_r2633382558
##########
index.d.ts:
##########
@@ -198,6 +202,22 @@ export interface TopicMetadata {
*/
export type MessageRouter = (message: Message, topicMetadata: TopicMetadata)
=> number;
+export interface EncryptionKey {
+ key: string;
+ value: string;
Review Comment:
The value should be a byte array. In C++, `std::string` could also used as a
byte array, but in Node.js, `Buffer` should be used as a byte array.
Sorry for not documenting which fields should represent byte array in
`EncryptionContext`, but I just checked the implementation and confirmed the
following fields should be bytes rather than strings:
- `EncryptionKey::value`
- `param`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
