oneby-wang commented on code in PR #25091:
URL: https://github.com/apache/pulsar/pull/25091#discussion_r2639126064
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -693,6 +694,9 @@ public CompletableFuture<AnalyzeBacklogResult>
analyzeBacklog(Optional<Position>
}
long num = entries.incrementAndGet();
messages.addAndGet(numMessages);
+ if (messageMetadata.hasMarkerType()) {
+ markerMessages.addAndGet(numMessages);
+ }
Review Comment:
> the filter shouldn't be evaluated and the counters shouldn't be incremented
When doing this improvement, I also have some doubts about marker messages
and entry filters. Thanks for clearing this up for me.
So, if a message is a marker message, we just increment `markerMessages` and
leave out the rest, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
