zjxxzjwang commented on code in PR #25010:
URL: https://github.com/apache/pulsar/pull/25010#discussion_r2643002500
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2042,6 +2042,13 @@ protected void handleSend(CommandSend send, ByteBuf
headersAndPayload) {
producer.publishMessage(send.getProducerId(),
send.getSequenceId(), headersAndPayload,
send.getNumMessages(), send.isIsChunk(), send.isMarker(),
position);
}
+
+ // count delayed message times exceeding the ttl policy time
+ MessageMetadata msgMetadata =
Commands.parseMessageMetadata(headersAndPayload);
+ if (msgMetadata.hasDeliverAtTime() && service.getPulsar()
+ .isMessageDelayTimeExceedTTL(producer.getTopic(),
msgMetadata.getDeliverAtTime())) {
+ producer.getTopic().incrementExceedTTLDelayMessages();
+ }
Review Comment:
Alright, I'll make some adjustments
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -2252,4 +2252,17 @@ public HealthChecker getHealthChecker() {
}
return healthChecker;
}
+
+ /**
+ * Check if message delay time exceeds TTL
+ *
+ * @param topic
+ * @param deliverAtTime
+ * @return true if message delay time exceeds TTL, false otherwise
+ */
+ public boolean isMessageDelayTimeExceedTTL(Topic topic, long
deliverAtTime) {
Review Comment:
Alright, I'll make some adjustments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
