BewareMyPower commented on code in PR #25119:
URL: https://github.com/apache/pulsar/pull/25119#discussion_r2656987692
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -1593,7 +1598,6 @@ public void operationFailed(ManagedLedgerException
exception) {
persistentMarkDeletePosition = null;
inProgressMarkDeletePersistPosition = null;
- lastMarkDeleteEntry = new MarkDeleteEntry(newMarkDeletePosition,
getProperties(), null, null);
Review Comment:
`lastMarkDeleteEntry` will be updated after `internalAsyncMarkDelete` is
done in `alignAcknowledgeStatusAfterPersisted`:
https://github.com/apache/pulsar/blob/ff0d0eb2ba97d96c8bc760a1dfe8255efa71d5c1/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L1534
Modifying it before the start of `internalAsyncMarkDelete` is duplicated and
does not make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
