lhotari commented on code in PR #25077:
URL: https://github.com/apache/pulsar/pull/25077#discussion_r2657481620
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SharedConsumerAssignor.java:
##########
@@ -58,7 +62,11 @@ public Map<Consumer, List<EntryAndMetadata>> assign(final
List<EntryAndMetadata>
Consumer consumer = getConsumer(numConsumers);
if (consumer == null) {
- entryAndMetadataList.forEach(EntryAndMetadata::release);
+ if (subscription != null) {
+ log.info("No consumer found to assign in topic:{},
subscription:{}, redelivering {} messages.",
+ subscription.getTopic().getName(),
subscription.getName(), entryAndMetadataList.size());
+ }
Review Comment:
this logging could be very noisy. I think it's better to use debug level
logging instead since it's a normal condition that there might not be any
consumers available with permits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
