oneby-wang commented on issue #25128: URL: https://github.com/apache/pulsar/issues/25128#issuecomment-3722133226
Besides this, I also found that some methods implement async and async operations using nearly the same logic separately in `AdminResource` and its super class `PulsarWebResource`. I’m wondering why we don’t just call the async method directly in the sync method and wait for the result to return. They should produce the same result. https://github.com/apache/pulsar/blob/d72dc04549b29d5ca73bf742aa81efa74ea107c4/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L454-L472 https://github.com/apache/pulsar/blob/d72dc04549b29d5ca73bf742aa81efa74ea107c4/pulsar-broker/src/main/java/org/apache/pulsar/broker/web/PulsarWebResource.java#L397-L439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
