dontgitit opened a new pull request, #25140: URL: https://github.com/apache/pulsar/pull/25140
Fixes [issue discussed on Slack](https://apache-pulsar.slack.com/archives/C5ZSVEN4E/p1768277318266049) ### Motivation While trying to implement a very similar component, I was poking around the `ProducerCache` and noticed that `closeAsync` was invoked without waiting for `flushAsync` to complete. I believe this could lead to correctness issues. ### Modifications I've simplified the code to directly call `flushAsync`, rather than start a future that calls it. ### Verifying this change - [x] Make sure that the change passes the CI checks. This change attempted to add tests, but they currently fail because the existing test harness makes false assumptions / the code it's testing doesn't actually work (specifically, `ProducerCache.close` doesn't actually wait for cache removal listener futures). ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> <!-- After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
