crossoverJie commented on code in PR #1456:
URL: https://github.com/apache/pulsar-client-go/pull/1456#discussion_r2696629964
##########
pulsar/consumer_regex.go:
##########
@@ -454,6 +481,11 @@ func (c *regexConsumer) topics() ([]string, error) {
}
filtered := filterTopics(topics, c.pattern)
+
+ if c.options.RetryEnable && c.options.DLQ != nil {
+ filtered = append(filtered, c.options.DLQ.RetryLetterTopic)
Review Comment:
> Appending the retry letter topic to the filtered topics list may cause
issues during auto-discovery.
https://github.com/apache/pulsar-client-go/blob/918d9731363861acd967ae4460b48cf711f2bdbc/pulsar/consumer_regex.go#L397-L402
The `discover` function is called repeatedly; without write validation,
`retryTopic` will be written repeatedly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
