lhotari commented on code in PR #25188:
URL: https://github.com/apache/pulsar/pull/25188#discussion_r2737619434
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java:
##########
@@ -80,37 +78,39 @@ public PatternMultiTopicsConsumerImpl(TopicsPattern
topicsPattern,
super(client, conf, executorProvider, subscribeFuture, schema,
interceptors,
false /* createTopicIfDoesNotExist */);
this.topicsPattern = topicsPattern;
- this.topicsHash = topicsHash;
this.subscriptionMode = subscriptionMode;
this.namespaceName = topicsPattern.namespace();
-
this.topicsChangeListener = new PatternTopicsChangedListener();
this.updateTaskQueue = new PatternConsumerUpdateQueue(this);
if (subscriptionMode == Mode.PERSISTENT) {
- long watcherId = client.newTopicListWatcherId();
- topicListWatcher = new TopicListWatcher(updateTaskQueue, client,
topicsPattern, watcherId,
- namespaceName, topicsHash, watcherFuture, () ->
recheckTopicsChangeAfterReconnect());
- watcherFuture
- .exceptionally(ex -> {
- if (closed) {
- log.warn("Pattern consumer [{}] was closed while
creating topic list watcher",
- conf.getSubscriptionName(), ex);
- } else {
- log.warn(
- "Pattern consumer [{}] unable to create topic
list watcher. Falling back to only polling"
- + " for new topics",
conf.getSubscriptionName(), ex);
- this.recheckPatternTimeout = client.timer()
- .newTimeout(this, Math.max(1,
conf.getPatternAutoDiscoveryPeriod()), TimeUnit.SECONDS);
- }
- return null;
- });
+ subscribeFuture.whenComplete((__, exception) -> {
+ if (!closed && exception == null) {
+ long watcherId = client.newTopicListWatcherId();
+ topicListWatcher = new TopicListWatcher(updateTaskQueue,
client, topicsPattern, watcherId,
+ namespaceName, this::getLocalStateTopicsHash,
watcherFuture,
+ this::getNextRecheckPatternEpoch);
Review Comment:
this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
