michaeljmarshall commented on code in PR #25197:
URL: https://github.com/apache/pulsar/pull/25197#discussion_r2744672310
##########
pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/AuthenticationProviderOpenID.java:
##########
@@ -445,7 +445,6 @@ DecodedJWT verifyJWT(PublicKey publicKey,
.withAnyOfAudience(allowedAudiences)
.withClaimPresence(RegisteredClaims.ISSUED_AT)
.withClaimPresence(RegisteredClaims.EXPIRES_AT)
- .withClaimPresence(RegisteredClaims.NOT_BEFORE)
Review Comment:
I verified that
https://openid.net/specs/openid-connect-basic-1_0.html#IDToken does not
indicate that the `nbf` claim is required and
https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.5 (the rfc
responsible for the json web token spec) indicates the `nbf` claim is optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
