BewareMyPower commented on code in PR #25187:
URL: https://github.com/apache/pulsar/pull/25187#discussion_r2752362297
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java:
##########
@@ -598,8 +610,10 @@ protected static <T> CompletableFuture<T>
alreadyClosedFailedFuture() {
@Override
public void close() throws Exception {
- executor.shutdownNow();
- executor.awaitTermination(10, TimeUnit.SECONDS);
+ serDesExecutor.shutdown();
+ schedulerExecutor.shutdown();
Review Comment:
The `shutdowNow` and `awaitTermination` combination is overkill in this
case. They should only be used when the executor might execute blocking
operations like `future.get()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
