lhotari commented on code in PR #25211:
URL: https://github.com/apache/pulsar/pull/25211#discussion_r2767577961
##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/AdminProxyHandler.java:
##########
@@ -117,84 +112,15 @@ class AdminProxyHandler extends ProxyServlet {
@Override
protected HttpClient createHttpClient() throws ServletException {
- ServletConfig config = getServletConfig();
-
- HttpClient client = newHttpClient();
-
- client.setFollowRedirects(true);
-
- // Must not store cookies, otherwise cookies of different clients will
mix.
- client.setHttpCookieStore(new HttpCookieStore.Empty());
-
- Executor executor;
- String value = config.getInitParameter("maxThreads");
- if (value == null || "-".equals(value)) {
- executor = (Executor)
getServletContext().getAttribute("org.eclipse.jetty.server.Executor");
- if (executor == null) {
- throw new IllegalStateException("No server executor for
proxy");
- }
- } else {
- QueuedThreadPool qtp = new
QueuedThreadPool(Integer.parseInt(value));
- String servletName = config.getServletName();
- int dot = servletName.lastIndexOf('.');
- if (dot >= 0) {
- servletName = servletName.substring(dot + 1);
- }
- qtp.setName(servletName);
- executor = qtp;
- }
-
- client.setExecutor(executor);
-
- value = config.getInitParameter("maxConnections");
- if (value == null) {
- value = "256";
- }
- client.setMaxConnectionsPerDestination(Integer.parseInt(value));
-
- value = config.getInitParameter("idleTimeout");
- if (value == null) {
- value = "30000";
- }
- client.setIdleTimeout(Long.parseLong(value));
-
- value = config.getInitParameter(INIT_PARAM_REQUEST_BUFFER_SIZE);
- if (value != null) {
- client.setRequestBufferSize(Integer.parseInt(value));
- }
-
- value = config.getInitParameter("responseBufferSize");
- if (value != null){
- client.setResponseBufferSize(Integer.parseInt(value));
- }
-
- try {
- client.start();
-
- // Content must not be decoded, otherwise the client gets confused.
- // Allow encoded content, such as "Content-Encoding: gzip", to
pass through without decoding it.
- client.getContentDecoderFactories().clear();
-
- // Pass traffic to the client, only intercept what's necessary.
- ProtocolHandlers protocolHandlers = client.getProtocolHandlers();
- protocolHandlers.clear();
- protocolHandlers.put(new RedirectProtocolHandler(client));
- protocolHandlers.put(new ProxyContinueProtocolHandler());
-
- return client;
- } catch (Exception x) {
- throw new ServletException(x);
- }
+ HttpClient httpClient = super.createHttpClient();
Review Comment:
Please remove `class ProxyContinueProtocolHandler extends
ContinueProtocolHandler` later in this class since it's now unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
