lhotari commented on code in PR #25252:
URL: https://github.com/apache/pulsar/pull/25252#discussion_r2826378521
##########
pulsar-client-admin-shaded/pom.xml:
##########
@@ -339,10 +339,6 @@
<shadedPattern>META-INF/versions/$1/org/apache/pulsar/shade/org/yaml/</shadedPattern>
<rawString>true</rawString>
</relocation>
- <relocation>
- <pattern>net.jcip</pattern>
-
<shadedPattern>org.apache.pulsar.shade.net.jcip</shadedPattern>
- </relocation>
Review Comment:
We should also shade the spotbugs-annotations since the classfiles get
included in the shaded jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
