lhotari commented on code in PR #25193:
URL: https://github.com/apache/pulsar/pull/25193#discussion_r2832096269


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/validator/StructSchemaDataValidator.java:
##########
@@ -49,7 +52,7 @@ public void validate(SchemaData schemaData) throws 
InvalidSchemaDataException {
         byte[] data = schemaData.getData();
 
         try {
-            Schema.Parser avroSchemaParser = new Schema.Parser();
+            Schema.Parser avroSchemaParser = new 
Schema.Parser(COMPATIBLE_NAME_VALIDATOR);

Review Comment:
   `pulsar-common` is also used on broker side, so how could it be separated? I 
would assume that it would make sense to cover both client + broker to use the 
`COMPATIBLE_NAME_VALIDATOR` in the avro schema parser in all locations. It 
should be a task that Claude Code could handle without much intervention.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to