soyji opened a new pull request, #656:
URL: https://github.com/apache/pulsar-helm-chart/pull/656

   Fixes #651
   
   ### Motivation
   
   The goal is to fix a indentation issue causing the dekaf deployment helm 
template not to render properly when setting extra volumes, this is useful when 
you mount a jwt token for authenticating with dekaf
   
   ### Modifications
   
   Set the identation from 8 to 6
   
   ### Verifying this change
   Go to `pulsar-helm-chart/charts/pulsar`
   
   Create test-values.yaml:
   ```
   components:
     dekaf: true
   
   dekaf:
     persistence:
       storageClass: "gp3"
     deployment:
       extraEnv:
       - name: DEKAF_PUBLIC_BASE_URL
         value: "http://dekaf-int-dev.test.com";
       extraVolumeMounts:
         - name: admin-token
           mountPath: /pulsar/tokens/admin
           readOnly: true
       extraVolumes:
         - name: admin-token
           secret:
             secretName: pulsar-token-admin
   ```
   
   Running `helm template pulsar . -f test-values.yaml --show-only 
templates/dekaf-deployment.yaml` renders properly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to