Copilot commented on code in PR #1465:
URL: https://github.com/apache/pulsar-client-go/pull/1465#discussion_r2850552172
##########
pulsaradmin/pkg/admin/namespace.go:
##########
@@ -302,6 +322,14 @@ type Namespaces interface {
// GetMaxConsumersPerTopicWithContext returns the maxProducersPerTopic
for a namespace. Returns -1 if not set
GetMaxConsumersPerTopicWithContext(ctx context.Context, namespace
utils.NameSpaceName) (int, error)
Review Comment:
The doc comments for GetMaxConsumersPerTopic /
GetMaxConsumersPerTopicWithContext incorrectly say they return
"maxProducersPerTopic". This looks like a copy/paste error and should reference
maxConsumersPerTopic instead to avoid misleading API consumers.
##########
pulsaradmin/pkg/admin/namespace.go:
##########
@@ -94,6 +94,12 @@ type Namespaces interface {
// GetNamespaceMessageTTLWithContext returns the message TTL for a
namespace. Returns -1 if not set
GetNamespaceMessageTTLWithContext(ctx context.Context, namespace
string) (int, error)
+ // RemoveNamespaceMessageTTL removes the message TTL configuration for
a namespace, defaulting to broker settings
+ RemoveNamespaceMessageTTL(namespace string) error
+
+ // RemoveNamespaceMessageTTLWithContext removes the message TTL
configuration for a namespace, defaulting to broker settings
+ RemoveNamespaceMessageTTLWithContext(ctx context.Context, namespace
string) error
Review Comment:
The PR description still contains template placeholders (e.g., `Fixes
#<xyz>`, `Master Issue: #<xyz>`) and unchecked verification items. Please
either fill these out or remove the template text so the PR metadata matches
the actual change intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
