lhotari commented on code in PR #25274:
URL: https://github.com/apache/pulsar/pull/25274#discussion_r2872502040
##########
conf/pulsar_env.sh:
##########
@@ -90,7 +90,7 @@ if [[ -z "$PULSAR_GC_LOG" ]]; then
fi
# Extra options to be passed to the jvm
-PULSAR_EXTRA_OPTS="${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true
-Dio.netty.recycler.maxCapacityPerThread=4096"}"
+PULSAR_EXTRA_OPTS="${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true
-Dio.netty.recycler.maxCapacityPerThread=4096
-Dio.netty.allocator.maxOrder=10"}"
Review Comment:
This would result in the expected behavior that the default chunk size would
always be set. If the user sets `PULSAR_EXTRA_OPTS`, this setting wouldn't be
used. There's an old issue #13382 about the problem.
The solution for this problem would be to prepend the arguments to `OPTS` so
that the defaults could be overridden with `PULSAR_EXTRA_OPTS` or `OPTS`.
```shell
OPTS="-Dpulsar.allocator.exit_on_oom=true
-Dio.netty.recycler.maxCapacityPerThread=4096 -Dio.netty.allocator.maxOrder=10
$OPTS"
```
This would also resolve #13382.
A similar solution was implemented in #23846.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
