geniusjoe commented on code in PR #25274:
URL: https://github.com/apache/pulsar/pull/25274#discussion_r2878773792


##########
bin/function-localrunner:
##########
@@ -76,8 +76,11 @@ if [[ -z "$PULSAR_GC_LOG" ]]; then
   fi
 fi
 
-# Extra options to be passed to the jvm
-PULSAR_EXTRA_OPTS=${PULSAR_EXTRA_OPTS:-" -Dpulsar.allocator.exit_on_oom=true 
-Dio.netty.recycler.maxCapacityPerThread=4096"}
+# Extra options to be passed to the jvm,typically used for passing 
user-defined JVM OPTS configurations.
+# This PULSAR_EXTRA_OPTS parameter has a higher priority than the predefined 
JVM OPTS.
+# Therefore, in addition to defining extra JVM parameters here, it can also be 
used to override JVM parameters with the same name in OPTS
+# For example, if IPv6 functionality needs to be enabled, configure: 
PULSAR_EXTRA_OPTS="-Djava.net.preferIPv4Stack=false".
+PULSAR_EXTRA_OPTS="${PULSAR_EXTRA_OPTS}"

Review Comment:
   The duplicate initialization code for `PULSAR_EXTRA_OPTS`, along with its 
corresponding comments, has been removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to