BewareMyPower commented on code in PR #543:
URL: https://github.com/apache/pulsar-client-cpp/pull/543#discussion_r2881456044
##########
lib/CMakeLists.txt:
##########
@@ -41,6 +41,7 @@ else ()
set(PULSAR_SOURCES ${PULSAR_SOURCES} ${PROTO_SOURCES})
ADD_CUSTOM_COMMAND(
OUTPUT ${PROTO_SOURCES}
+ COMMAND ${CMAKE_COMMAND} -E echo "Generating PulsarApi.pb.cc/h
with: ${PROTOC_PATH} -I ../proto ../proto/PulsarApi.proto
--cpp_out=${LIB_AUTOGEN_DIR}"
Review Comment:
This change is not necessary
##########
LegacyFindPackages.cmake:
##########
@@ -79,6 +79,10 @@ if (APPLE)
set(OPENSSL_ROOT_DIR ${OPENSSL_ROOT_DIR} /usr/local/opt/openssl/
/opt/homebrew/opt/openssl)
endif ()
find_package(OpenSSL REQUIRED)
+# Ensure OPENSSL_LIBRARIES is a proper CMake list (ssl and crypto as separate
entries)
Review Comment:
Changes on this file are not related, please revert them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
