shibd opened a new pull request, #462:
URL: https://github.com/apache/pulsar-client-node/pull/462

   Master Issue: #431
   
   ## Motivation
   The @mapbox/[email protected] dependency has several deprecated packages 
that generate warnings during npm install, including:
   
   - [email protected]
   - [email protected]
   - [email protected]
   - [email protected]
   - [email protected]
   - [email protected]
   
   These deprecation warnings clutter the installation output and may indicate 
security or maintenance issues. Additionally, there were linker warnings during 
build on macOS due to a version mismatch between the deployment target (11.0) 
and the pre-compiled C++ client library (macOS 13.0).
   
   ## Modifications
   
   1. Upgraded @mapbox/node-pre-gyp from 1.0.11 to 2.0.3 in package.json: This 
version (released Nov 26, 2025) removes all deprecated dependencies
   2. Changed MACOSX_DEPLOYMENT_TARGET from 11.0 to 13.0
   ```
   This matches the pre-compiled C++ client library version and eliminates 
linker warnings
   The warnings appeared as: ld: warning: object file was built for newer 
'macOS' version (13.0) than being linked (11.0)
   ```
   ## Verifying this change
   
   1.  Verified that npm install no longer shows deprecation warnings from 
@mapbox/node-pre-gyp dependencies
   2.  Verified that npx node-pre-gyp build completes successfully
   3.  Verified that the binary lib/binding/pulsar.node is generated correctly 
(12M, Mach-O 64-bit bundle arm64)
   4.  Verified that linker warnings about macOS version mismatch no longer 
appear during build
   5.  Make sure that this change passes CI checks.
   6. This change is already covered by existing tests, such as the existing 
build and integration tests in the repository that verify the native addon 
compiles and runs correctly.
   
   
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to