massakam opened a new pull request, #25281:
URL: https://github.com/apache/pulsar/pull/25281

   ### Motivation
   
   Brokers and proxies can continue to provide services even if more than half 
of the ZooKeeper servers acting as configuration metadata store go down and 
switch to read-only mode by writing `metadataStoreAllowReadOnlyOperations=true` 
in their configuration files.
   
   - https://github.com/apache/pulsar/pull/19156
   - https://github.com/apache/pulsar/pull/19246
   
   On the other hand, WebSocket servers could not continue to provide services 
even though `metadataStoreAllowReadOnlyOperations=true` was written in the 
configuration file.
   
   This is because the `metadataStoreAllowReadOnlyOperations` field exists in 
the 
[ServiceConfiguration](https://github.com/apache/pulsar/blob/d992dc530bea4f4737da93f1527133b1c9389a45/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java#L505-L509)
 and 
[ProxyConfiguration](https://github.com/apache/pulsar/blob/d992dc530bea4f4737da93f1527133b1c9389a45/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java#L138-L142)
 classes, but not in the 
[WebSocketProxyConfiguration](https://github.com/apache/pulsar/blob/d992dc530bea4f4737da93f1527133b1c9389a45/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java)
 class.
   
   ### Modifications
   
   Added the `metadataStoreAllowReadOnlyOperations` field to the 
`WebSocketProxyConfiguration` class.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to