codelipenghui commented on code in PR #25282:
URL: https://github.com/apache/pulsar/pull/25282#discussion_r2887150448


##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/Backoff.java:
##########
@@ -95,6 +98,8 @@ public void reduceToHalf() {
 
     public void reset() {
         this.next = this.initial;
+        this.firstBackoffTimeInMillis = 0;
+        this.firstBackoffTimeInMillisSet = false;

Review Comment:
   The PR modifies reset() to clear both firstBackoffTimeInMillis and 
firstBackoffTimeInMillisSet, but relies on the existing mandatoryStopTest for
     implicit coverage. An explicit test for "reset then new mandatory stop 
cycle" would strengthen confidence



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to