poorbarcode commented on code in PR #25293: URL: https://github.com/apache/pulsar/pull/25293#discussion_r2945706148
########## pulsar-broker/src/main/java/org/apache/pulsar/utils/SimpleCache.java: ########## Review Comment: > computeIfAbsent would be used to ensure that duplicates aren't added to the map and locking could be handled in ExpirableValue level to avoid shared locks and just have a per-key lock. Since the previous implementation initialised the reader synchronously, the method `computeIfAbsent` will be stuck, and following requests will also be stuck until the first request is done, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
