chamons opened a new pull request, #25681: URL: https://github.com/apache/pulsar/pull/25681
Fixes https://github.com/apache/pulsar/issues/25617 ### Motivation DelayedDeliveryTracker is not thread safe, and any access to it must be done holding the object lock. This is a significant issue, as exceptions here were uncaught and put the broker into an invalid state that prevented some delayed messages from being delivered until restart. ### Modifications There were five cases I found, three of them I could correct just by adding synchronized to the method declaration. Two of them were overrides and were corrected using a manual locking scope. ### Verifying this change - [ ] Make sure that the change passes the CI checks. The included unit test failed 100% of the time when run locally without the fix, and we were able to run https://github.com/chamons/pulsar-scheduled-exception-repro without issues with the fix included. ### Does this pull request potentially affect one of the following parts: *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
