merlimat opened a new pull request, #25712:
URL: https://github.com/apache/pulsar/pull/25712

   ## Summary
   
   `ScalableTopicController` and `ScalableTopicService` each carried a 
`registerConsumer` overload that defaulted `ScalableConsumerType` to `STREAM` 
"for backward compatibility". The only production caller (`ServerCnx`) already 
passes the explicit type, so the overloads served only stale test code and were 
leaving deprecation warnings on every broker test compile.
   
   Removed both overloads. Updated their only callers — broker tests 
(`ScalableTopicControllerTest`, `ScalableTopicServiceTest`) — to pass 
`ScalableConsumerType.STREAM` explicitly. No production behavior change.
   
   ## Test plan
   
   - [x] `pulsar-broker` compile + checkstyle clean.
   - [x] `ScalableTopicControllerTest` 31/31 pass.
   - [x] `ScalableTopicServiceTest` 16/16 pass.
   - [x] No more `[deprecation] registerConsumer` warnings in the broker test 
compile output.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to