lhotari commented on code in PR #25681:
URL: https://github.com/apache/pulsar/pull/25681#discussion_r3207375898
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -1389,7 +1389,9 @@ public CompletableFuture<Void> clearDelayedMessages() {
}
if (delayedDeliveryTracker.isPresent()) {
- return this.delayedDeliveryTracker.get().clear();
+ synchronized (this) {
+ return this.delayedDeliveryTracker.get().clear();
+ }
Review Comment:
for consistency, it could be useful to make the method itself
`synchronized`. That would also cover the `BucketDelayedDeliveryTrackerFactory`
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
